Re: [PATCH net-next 0/6] net/ncsi: Allow enabling multiple packages & channels
From: Samuel Mendoza-Jonas
Date: Mon Oct 22 2018 - 18:24:32 EST
On Fri, 2018-10-19 at 21:38 +0000, Justin.Lee1@xxxxxxxx wrote:
> Hi Sam,
> When I run the testing (enable multi-package (package 0 and 1) and
> multi-channel (channel 0 and 1 on both packages)), I see there are two channels
> with TX enable.
> When I unplug/plug network cable, it seems the behavior is to keep one TX per
> package, is it the behavior you expect? All channels are behind the same eth2,
> I would expect there is only one active TX.
> I create the below file to expose driver's status. RX and TX are printing
> from the follow variables.
> cat /sys/kernel/debug/ncsi_protocol/ncsi_device_status;
> IFIDX IFNAME NAME PID CID RX TX MP MC WP WC PS RU CR NQ
> 2 eth2 ncsi0 000 000 1 1 1 1 1 1 1 1 1 0
> 2 eth2 ncsi1 000 001 1 0 1 1 1 1 1 1 1 0
> 2 eth2 ncsi2 001 000 1 1 1 1 1 1 1 1 1 0
> 2 eth2 ncsi3 001 001 1 0 1 1 1 1 1 1 1 0
> M: Multi-mode P: Package ID
> W: Whitelist C: Channel ID
> PS: Poll Status
> RU: Running
> CR: Carrier OK
> NQ: Queue Stopped
Thanks for testing; this is probably an oversight in
ncsi_channel_is_tx(), where channels from a package other than the
current one could be ignored when checking for the current channel's link
status. I'll update this to be more robust.
> From: Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>
> Date: Thu, 18 Oct 2018 14:59:11 +1100
> > This series extends the NCSI driver to configure multiple packages
> > and/or channels simultaneously. Since the RFC series this includes a few
> > extra changes to fix areas in the driver that either made this harder or
> > were roadblocks due to deviations from the NCSI specification.
> > Patches 1 & 2 fix two issues where the driver made assumptions about the
> > capabilities of the NCSI topology.
> > Patches 3 & 4 change some internal semantics slightly to make multi-mode
> > easier.
> > Patch 5 introduces a cleaner way of reconfiguring the NCSI configuration
> > and keeping track of channel states.
> > Patch 6 implements the main multi-package/multi-channel configuration,
> > configured via the Netlink interface.
> > Readers who have an interesting NCSI setup - especially multi-package
> > with HWA - please test! I think I've covered all permutations but I
> > don't have infinite hardware to test on.