Re: [PATCH v2] wireless: mark expected switch fall-throughs

From: Gustavo A. R. Silva
Date: Tue Oct 23 2018 - 05:49:23 EST



On 10/23/18 9:01 AM, Johannes Berg wrote:
> On Tue, 2018-10-23 at 02:13 +0200, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This code was not tested and GCC 7.2.0 was used to compile it.
>
> Look, I'm not going to make this any clearer: I'm not applying patches
> like that where you've invested no effort whatsoever on verifying that
> they're correct.
>

How do you suggest me to verify that every part is correct in this type
of patches?

Thanks
--
Gustavo