Re: [PATCH v2 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status

From: Mathias Nyman
Date: Tue Oct 23 2018 - 06:39:13 EST


On 22.10.2018 20:42, Aaron Ma wrote:
Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3,
after clear port reset it works fine.

Since this device is registered on USB3 roothub at boot,
when port status reports not superspeed, xhci_get_port_status will call
an uninitialized completion in bus_state[0].
Kernel will hang because of NULL pointer.

Restrict the USB2 resume status check in USB2 roothub to fix hang issue.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>

Thanks, adding to queue, will send forward after rc1

-Mathias