Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

From: Martin K. Petersen
Date: Wed Oct 24 2018 - 00:31:50 EST



Nathan,

> Clang warns a few times:
>
> drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to
> 'char' changes value from 128 to -128 [-Wconstant-conversion]
> cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */
> ~ ^~~~~~~~~~~~~~~~~~~~
>
> Update cdb's type to unsigned char, which matches the type of the cdb
> member in struct TW_Command_Apache.

Applied to 4.20/scsi-queue. Thank you.

--
Martin K. Petersen Oracle Linux Engineering