Re: [PATCH v2 2/3] leds: upboard: Add LED support
From: Joe Perches
Date: Wed Oct 24 2018 - 06:24:51 EST
On Wed, 2018-10-24 at 13:13 +0300, Andy Shevchenko wrote:
> On Tue, Oct 23, 2018 at 12:23:13PM -0700, Joe Perches wrote:
> > Until such a time when either a local preferred style
> > document or a treewide preferred style exists, please
> > stop asking people to modify #include ordering for
> > various styles like reverse christmas tree by length,
> > alphabetic ordering, or other individual styles.
> Why? It makes a sense to ask for new code (and even for patches against old one in some cases).
It's just a nit and frequently impossible to require as
ordering dependencies between include files do exist.
> > My preferred style would always have kernel.h first
> > as that may help with precompiled headers and overall
> > kernel compilation time one day.
> How ordering would screw this up?
gcc has many limits on the use of precompiled headers.
Precompiled headers are often shared by multiple
compilation units and precompilation can be stopped
after a specific header.