Re: [PATCH] ocfs2: dlmfs: remove set but not used variable 'status'

From: Joseph Qi
Date: Wed Oct 24 2018 - 06:38:03 EST




On 18/10/23 21:09, zhong jiang wrote:
> status is not used after setting its value. It is safe to remove
> the unused variable.
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>

Acked-by: Joseph Qi <jiangqi903@xxxxxxxxx>

> ---
> fs/ocfs2/dlmfs/dlmfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
> index 642e471..b03dd46 100644
> --- a/fs/ocfs2/dlmfs/dlmfs.c
> +++ b/fs/ocfs2/dlmfs/dlmfs.c
> @@ -179,7 +179,7 @@ static int dlmfs_file_open(struct inode *inode,
> static int dlmfs_file_release(struct inode *inode,
> struct file *file)
> {
> - int level, status;
> + int level;
> struct dlmfs_inode_private *ip = DLMFS_I(inode);
> struct dlmfs_filp_private *fp = file->private_data;
>
> @@ -188,7 +188,6 @@ static int dlmfs_file_release(struct inode *inode,
>
> mlog(0, "close called on inode %lu\n", inode->i_ino);
>
> - status = 0;
> if (fp) {
> level = fp->fp_lock_level;
> if (level != DLM_LOCK_IV)
>