Re: [PATCH v2 0/3] UP Squared board drivers
From: Andy Shevchenko
Date: Wed Oct 24 2018 - 09:05:12 EST
On Fri, Oct 19, 2018 at 06:15:31PM +0100, Dan O'Donovan wrote:
> Hi all,
> This series adds platform support for AAEON's UP Squared, a x86 SBC
> based on Apollo Lake . Specifically, it enables control for the board
> pin headers and for the LEDs, as both of these features are only
> available behind a FPGA-based platform controller.
> This is structured around a MFD driver that provides a regmap interface
> to that platform controller to each MFD cell.
> The series is carved out from an out-of-tree support patchset, initially
> written for the original UP Board  and then extended through the past
> year to support new entries in the lineup (UP Board, UP Squared and
> UP Core) .
> Here we only submit support for UP Squared to simplify review. Still,
> the driver is designed so that it can easily gain support for the other
> V1 was originally submitted by Javier Arteaga in April 2018 as an RFC .
> This V2 aims to address the feedback gratefully received from that.
Are you attending ELCE in Edinburgh?
> : http://www.up-board.org/upsquared/specifications-up2/
> : https://lkml.kernel.org/r/1467648434-29080-1-git-send-email-dan@xxxxxxxxxx
> : https://github.com/emutex/ubilinux-kernel/commits/upboard-4.9
> : https://lore.kernel.org/lkml/20180421085009.28773-1-javier@xxxxxxxxxx/
> * Rewrote regmap r/w handlers to avoid duplication and improve readability
> * Simplified data passing between MFD parent and child device drivers
> * Removed incorrect __init attribute from probe functions
> * Moved MFD cell definitions into same patch as MFD driver and simplified them
> * Promoted some dev_dbg instances to dev_err for probe error cases
> * Decoupled MFD cell reference from ACPI driver data
> * Miscellanous coding style improvements
> * Fixed license mismatches
> Javier Arteaga (3):
> mfd: upboard: Add UP2 platform controller driver
> leds: upboard: Add LED support
> pinctrl: upboard: Add UP2 pinctrl and gpio driver
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-upboard.c | 104 ++++++++
> drivers/mfd/Kconfig | 17 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/upboard.c | 344 +++++++++++++++++++++++++
> drivers/pinctrl/Kconfig | 13 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-upboard.c | 519 ++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/upboard.h | 44 ++++
> 10 files changed, 1054 insertions(+)
> create mode 100644 drivers/leds/leds-upboard.c
> create mode 100644 drivers/mfd/upboard.c
> create mode 100644 drivers/pinctrl/pinctrl-upboard.c
> create mode 100644 include/linux/mfd/upboard.h
> This email has been scanned for spam and malware by The Email Laundry.
With Best Regards,