Re: [PATCH] Change judgment len position

From: Eric Dumazet
Date: Wed Oct 24 2018 - 13:03:24 EST

On Wed, Oct 24, 2018 at 9:54 AM Joe Perches <joe@xxxxxxxxxxx> wrote:

> I think if the point is to test for negative numbers,
> it's clearer to do that before using min_t.and it's
> probably clearer not to use min_t at all.


> if (len > sizeof(int))
> len = sizeof(int);

It is a matter of taste really, I know some people (like me) sometimes
mixes min() and max()

I would suggest that if someones wants to change the current code, a
corresponding test
would be added in tools/testing/selftests/net