Re: KASAN: slab-out-of-bounds Read in string (2)
From: Bruce Fields
Date: Thu Oct 25 2018 - 11:02:22 EST
On Wed, Oct 24, 2018 at 06:40:35AM -0400, Jeff Layton wrote:
> On Wed, 2018-10-24 at 12:35 +0300, Amir Goldstein wrote:
> > > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> > > > index d35cd6be0675..93fb7cf0b92b 100644
> > > > --- a/fs/lockd/host.c
> > > > +++ b/fs/lockd/host.c
> > > > @@ -341,7 +341,7 @@ struct nlm_host *nlmsvc_lookup_host(const struct
> > > > svc_rqst *rqstp,
> > > > };
> > > > struct lockd_net *ln = net_generic(net, lockd_net_id);
> > > >
> > > > - dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__,
> > > > + dprintk("lockd: %s(host='%.*s', vers=%u, proto=%s)\n", __func__,
> > > > (int)hostname_len, hostname, rqstp->rq_vers,
> > > > (rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));
> > > >
> > >
> > > Why wasn't this one applied? It looks correct to me. The rest seem to
> > > have been fixed already.
> > >
> > I did not send this patch to Jeff.
> > Jeff was CC'ed on the patch I sent to Miklos
> > and Miklos decided to only take the overlayfs bits:
> > https://marc.info/?l=linux-unionfs&m=153847248625015&w=2
> > So I guess it has fallen between the cracks.
> > Feel free to send a patch to Jeff.
> > Thanks,
> > Amir.
> Actually, this should probably go to Bruce, as he mostly takes care of
> lockd. Patch looks correct though.
Yes, if you could resend I'd be happy to handle it.--b.