Re: [PATCH 1/2] spi: spi-geni-qcom: fix nitpicks
From: Doug Anderson
Date: Thu Oct 25 2018 - 16:01:09 EST
On Thu, Oct 25, 2018 at 9:40 AM Alok Chauhan <alokc@xxxxxxxxxxxxxx> wrote:
> fixed the nitpicks.
I probably would have put more a proper sentence, like:
Fixed small nits that were pointed out on the mailing list. No
functional change expected.
...but I guess it's up to Mark if he cares.
> @@ -533,7 +530,7 @@ static irqreturn_t geni_spi_isr(int irq, void *data)
> writel(m_irq, se->base + SE_GENI_M_IRQ_CLEAR);
> spin_unlock_irqrestore(&mas->lock, flags);
> - return ret;
> + return IRQ_HANDLED;
I probably would have put a blank line before the return while I was
at it, but it's not a big deal to me.
Thanks for following up.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>