Re: [PATCH 0/3] drm: tinydrm driver for adafruit PiTFT 3.5" touchscreen

From: Noralf TrÃnnes
Date: Thu Oct 25 2018 - 17:52:43 EST

Den 25.10.2018 18.29, skrev Eric Anholt:
Eric Anholt <eric@xxxxxxxxxx> writes:

I was going to start working on making the vc4 driver work with
tinydrm panels, but it turned out tinydrm didn't have the panel I had
previously bought. So, last night I ported the fbtft staging
driver over to DRM.

It seems to work (with DT at --
fbdev works great including rotated, and so does modetest. However,
when X11 comes up at 16bpp, I get:

If I have tinydrm set a preferred bpp of 24, X looks great. Noralf,
any ideas?
Also, with these patches and the format modifier patch I just sent, mesa
with vc4 is now working with this driver on this branch:

Ah, nice to see this happening!
Getting hw rendering was one of the advantages I saw DRM could provide
over fbdev on these displays. Little did I know how complicated graphics
was outside fbdev, so I was unable to realise this myself.

The current solution to get hw rendering is to have a userspace process
that continously copies the framebuffer:

It's used by some of the small DIY handheld game consoles that run
emulators which requires hw rendering.

Now I wonder how we can improve performance of the SPI updates.

At what SPI speed are you running? The datasheet for most of these
display controllers list the max speed as 10MHz, but almost all of them
can go faster. Some are reported going as high as 70-80MHz. That's for
the pixel data transfer, not the commands. tinydrm/mipi-dbi.c sends
commands at 10MHz and pixels at full speed (mipi_dbi_spi_cmd_max_speed()).
Most panels I have run at 32MHz or 48MHz.

Almost all the time is spent in the SPI transfer, so every hz counts. On
the Pi there's byte swapping because the DMA capable SPI controller can't
do 16-bit (tinydrm_swab16()). If I remember correctly this has negligible
impact on performance.

The SPI controller/driver on the Pi has some restrictions on the speeds
to choose from because the divisor has to be a multiple of two

A full update on a 320x480 RGB565 panel is 262.5kB, so it's a lot to push
over SPI. A 2.8" 320x240 panel is more suitable for video fps, because of
the lower resolution.

I'll look at the patches during the weekend.