Re: [PATCH] libosd: Remove ignored __weak attribute
From: Nick Desaulniers
Date: Fri Oct 26 2018 - 14:32:07 EST
On Fri, Oct 26, 2018 at 11:05 AM Nathan Chancellor
> On Fri, Oct 26, 2018 at 11:01:48AM -0700, Bart Van Assche wrote:
> > On Fri, 2018-10-26 at 10:54 -0700, Nick Desaulniers wrote:
> > > If creating one instance of this variable is a functional change, I
> > > can't help but suspect the original code was wrong. But maybe Bart,
> > > Boaz, or Christoph can clarify or have more thoughts on this? Looks
> > > like Boaz added this header in commit de258bf5e638 ("[SCSI] libosd:
> > > OSDv1 Headers").
> > Hi Nick and Nathan,
> > Had you noticed the following e-mail from early October:
> > https://marc.info/?l=linux-kernel&m=153849955503249?
> > Thanks,
> > Bart.
> Hi Bart,
> I had but there doesn't seem to be any reply to it so I wasn't sure if
> there was a final consensus on removing the driver. If that's the route
> that everyone wants to go, then I guess we don't need to continue to
> debate this patch.
> Thanks for the heads up,
I've staged a RFC patch here:
I'm not about the process of removing code from the kernel. Doesn't
that violate the "thou shalt not break userspace" rule? But code does
get deleted from the kernel... ex: