Re: Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()"
From: Rui Salvaterra
Date: Sun Oct 28 2018 - 04:53:49 EST
On Sun, 28 Oct 2018 at 01:02, Ming Lei <ming.lei@xxxxxxxxxx> wrote:
> On Fri, Oct 26, 2018 at 08:50:20AM +0100, Rui Salvaterra wrote:
> > On Fri, 26 Oct 2018 at 07:27, Ming Lei <ming.lei@xxxxxxxxxx> wrote:
> > >
> > > The patch titled with 'block: make sure discard bio is aligned with logical block size'
> > > in the list may fix this issue, please test and see if it works.
> > >
> > > Thanks,
> > > Ming
> > Hi, Ming,
> > Thanks for the quick reply. Unfortunately, it doesn't seem to apply
> > cleanly to 4.19. To which tree/tag/commit should I apply the series?
> The whole patchset is against linus tree (44786880df196a4200).
> I am sure that the 1st patch can be applied cleanly against v4.19, and
> it is enough for fixing this issue, please double check.
> [ming@ming linux]$ git log --oneline -1
> 84df9525b0c2 Linux 4.19
> [ming@ming linux]$ git am ~/emails/blk/181026\ \[PATCH\ 1â3\]\ block\:\ make\ sure\ discard\ bio\ is\ aligned\ with\ logical\ block\ size.eml
> Applying: block: make sure discard bio is aligned with logical block size
> [ming@ming linux]$
You're, right, of course. I had reverted the aforementioned commit, so
the patch set obviously wouldn't apply anymore. After checking out
v4.19 again, everything went smoothly. I confirm the patch set fixes
the issue for me, which means this series is
Tested-by: Rui Salvaterra <rsalvaterra@xxxxxxxxx>