Re: [PATCH V5] block: fix the DISCARD request merge

From: Christoph Hellwig
Date: Sun Oct 28 2018 - 11:48:39 EST


On Sat, Oct 27, 2018 at 07:52:14PM +0800, Jianchao Wang wrote:
> +enum elv_merge blk_try_req_merge(struct request *req, struct request *next)
> +{
> + if (blk_discard_mergable(req))
> + return ELEVATOR_DISCARD_MERGE;
> + else if (blk_rq_pos(req) + blk_rq_sectors(req) == blk_rq_pos(next))
> + return ELEVATOR_BACK_MERGE;
> +
> + return ELEVATOR_NO_MERGE;

The empty line here look a little odd, but if that is the only thing
I can nitpick about it must be great, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>