Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling
From: Jonathan Cameron
Date: Sun Oct 28 2018 - 12:52:10 EST
On Fri, 26 Oct 2018 22:59:59 -0300
Matheus Tavares <matheus.bernardino@xxxxxx> wrote:
> This patch set adds scale info to ad2s90's single channel, improve
> error handling in it's functions and fix a possible race condition
> The goal with this patch set is to address the points discussed in the
> mailing list in an effort to move ad2s90.c out of staging.
A good series in general. A few suggested improvements.
If I haven't commented on a patch, usually it means I'm happy with it
and will pick it up with the rest of the series.
> Changes in v2:
> - Added my S-o-B in patch 5.
> Matheus Tavares (5):
> staging:iio:ad2s90: Make read_raw return spi_read's error code
> staging:iio:ad2s90: Make probe handle spi_setup failure
> staging:iio:ad2s90: Remove always overwritten assignment
> staging:iio:ad2s90: Move device registration to the end of probe
> staging:iio:ad2s90: Check channel type at read_raw
> Victor Colombo (1):
> staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and
> drivers/staging/iio/resolver/ad2s90.c | 55 ++++++++++++++++++---------
> 1 file changed, 37 insertions(+), 18 deletions(-)