Re: [PATCH 8/9] w1: fix whitespaces of struct declarations
From: Joe Perches
Date: Sun Oct 28 2018 - 22:05:04 EST
On Mon, 2018-10-29 at 03:02 +0100, Steffen Vogel wrote:
> Hi Joe,
> v2 of this patch set is almost ready.
> I reran checkpatch.pl with '--strict'. So more warnings will be fixed by
> the second version.
> See my comments below.
> On Sun, Oct 28, 2018 at 06:52:23PM -0700, Joe Perches wrote:
> > On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> > > This fixes a warning raised by the checkpatch tool.
> > checkpatch does not raise any whitespace errors on
> > this file.
> > It does suggest that braces could be moved.
> Ah okay, I considered moving a brace also a whitespace change.
> Do you prefer the original indention of the struct members?
> I dont see it very often in kernel code.
The indentation doesn't matter to me.
The commit message description of a checkpatch warning
that does not exist is incorrect.