Re: [PATCH 2/8] ARM: vexpress/spc: constify clk_ops structure

From: Liviu Dudau
Date: Mon Oct 29 2018 - 05:18:01 EST


On Sat, Oct 27, 2018 at 07:47:36AM +0200, Julia Lawall wrote:
> The clk_ops structure is only stored in the ops field of a
> clk_init_data structure. This field is const, so the clk_ops
> structure can be const as well.
>
> Identified and transformed using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Acked-by: Liviu Dudau <liviu.dudau@xxxxxxx>

Are you going to send the series to the arm-soc maintainers directly or
you want us to cherry-pick this patch into the Versatile tree?

Best regards,
Liviu

>
> ---
> arch/arm/mach-vexpress/spc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c
> index 0f5381d13494..611f22de48cb 100644
> --- a/arch/arm/mach-vexpress/spc.c
> +++ b/arch/arm/mach-vexpress/spc.c
> @@ -521,7 +521,7 @@ static int spc_set_rate(struct clk_hw *hw, unsigned long rate,
> return ve_spc_set_performance(spc->cluster, rate / 1000);
> }
>
> -static struct clk_ops clk_spc_ops = {
> +static const struct clk_ops clk_spc_ops = {
> .recalc_rate = spc_recalc_rate,
> .round_rate = spc_round_rate,
> .set_rate = spc_set_rate,
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
Â\_(ã)_/Â