Re: [PATCH v2 1/3] linkage.h: Align weak symbols.
From: Will Deacon
Date: Mon Oct 29 2018 - 06:29:15 EST
On Thu, Sep 20, 2018 at 04:56:29PM +0300, Andrey Ryabinin wrote:
> Since WEAK() supposed to be used instead of ENTRY() to define weak
> symbols, but unlike ENTRY() it doesn't have ALIGN directive.
> It seems there is no actual reason to not have, so let's add
> ALIGN to WEAK() too.
> Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> include/linux/linkage.h | 1 +
> 1 file changed, 1 insertion(+)
Looks sensible to me:
Acked-by: Will Deacon <will.deacon@xxxxxxx>
> diff --git a/include/linux/linkage.h b/include/linux/linkage.h
> index d7618c41f74c..7c47b1a471d4 100644
> --- a/include/linux/linkage.h
> +++ b/include/linux/linkage.h
> @@ -90,6 +90,7 @@
> #ifndef WEAK
> #define WEAK(name) \
> .weak name ASM_NL \
> + ALIGN ASM_NL \