Re: [PATCH v4] kernel/signal: Signal-based pre-coredump notification
From: Oleg Nesterov
Date: Mon Oct 29 2018 - 07:18:19 EST
On 10/26, Enke Chen wrote:
> This is really a good idea given that "parent" is declared as RCU-protected.
> Just a bit odd, though, that the "parent" has not been accessed this way in
> the code base.
It is acccessed when possible,
> So just to confirm: the revised code would look like the following:
> static void do_notify_parent_predump(void)
> struct task_struct *parent;
> int sig;
> parent = rcu_dereference(current->parent);
> sig = parent->signal->predump_signal;
> if (sig != 0)
> do_send_sig_info(sig, SEND_SIG_NOINFO, parent, PIDTYPE_TGID);
Yes, this is what I meant.
But I still think do_notify_parent_predump() should notify ->real_parent,