Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP
From: Matthew Wilcox
Date: Mon Oct 29 2018 - 09:41:07 EST
On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote:
> +config DW_I3C_MASTER
> + tristate "Synospsys DesignWare I3C master driver"
> + depends on I3C
> + depends on !(ALPHA || PARISC)
> + help
> + Support·for·Synopsys·DesignWare·MIPI·I3C·Controller.
These strange characters (displayed as a centred dot on my terminal)
should probably be spaces.
> +static struct dw_i3c_xfer *
> +dw_i3c_master_alloc_xfer(struct dw_i3c_master *master, unsigned int ncmds)
> + struct dw_i3c_xfer *xfer;
> + xfer = kzalloc(sizeof(*xfer) + (ncmds * sizeof(*xfer->cmds)),
> + GFP_KERNEL);
You should be using struct_size() here.