Re: [PATCH 05/14] blk-mq: allow software queue to map to multiple hardware queues
From: Bart Van Assche
Date: Mon Oct 29 2018 - 13:34:41 EST
On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote:
+AD4 The mapping used to be dependent on just the CPU location, but
+AD4 now it's a tuple of +AHs type, cpu+AH0 instead. This is a prep patch
+AD4 for allowing a single software queue to map to multiple hardware
+AD4 queues. No functional changes in this patch.
A nitpick: mathematicians usually use the +AHs +AH0 notation for sets and () for
tuples. See also https://en.wikipedia.org/wiki/Tuple.
+AD4 +- /+ACo wrap +ACo-/
+AD4 +- BUG+AF8-ON(+ACE-hctx-+AD4-nr+AF8-ctx)+ADs
Another nitpick: how about changing the +ACI-wrap+ACI comment into +ACI-detect integer
overflow+ACI or so to make the purpose of the BUG+AF8-ON() statement more clear?