Re: [PATCH 01/21] of: Add cpu node iterator for_each_of_cpu_node()
From: Rob Herring
Date: Tue Oct 30 2018 - 11:00:33 EST
On Tue, Oct 30, 2018 at 9:20 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:
> > Hi Rob,
> > Sorry I missed this when you posted it.
> > Rob Herring <robh@xxxxxxxxxx> writes:
> >> Iterating thru cpu nodes is a common pattern. Create a common iterator
> >> which can find child nodes either by node name or device_type == cpu.
> >> Using the former will allow for eventually dropping device_type
> >> properties which are deprecated for FDT.
> > Device trees we see on powerpc generally don't (never?) use "cpu" as the
> > node name for CPU nodes. And many of those device trees come from
> > firmware, so we can't update them.
> > So dropping support for device_type is a non-starter from our POV.
> ps. presumably that's what you meant by deprecated *for FDT*.
> But anyway just wanted to make sure we are on the same page.
Yes, I was aware at least older powerpc DTs don't use 'cpu' for node names.