Re: [PATCH 2/2] net: xilinx_emaclite: recheck condition after timeout in mdio_wait()
From: David Miller
Date: Tue Oct 30 2018 - 14:25:31 EST
From: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2018 10:31:39 +0100
> The function could report a false positive if it gets preempted between reading
> the XEL_MDIOCTRL_OFFSET register and checking for the timeout. In such a case,
> the condition has to be rechecked to avoid false positives.
> Therefore, check for expected condition even after the timeout occurred.
> Signed-off-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
Same objections as your previous patch.
This isn't fixing anything.