Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Date: Tue Oct 30 2018 - 22:26:44 EST
å 2018å10æ30æ 17:23, Baoquan He åé:
> Hi Boris, DaveY and Lianbo,
> On 10/30/18 at 10:15am, Borislav Petkov wrote:
>> On Tue, Oct 30, 2018 at 01:09:00PM +0800, Dave Young wrote:
>>> It is not the content, I think it is a good catch from Boris, it would
>>> be good to document the exported things in somewhere eg.
> For the vmcoreinfo variables document, I personally think it might be
> not necessary. The reason is that all the old varialbles are exported
> with the name of themselves. We know what they are or what they
> represent since they are all kernel symbols or macro. Only this me_mask,
> it's a local variable and store the value of sme_me_mask for now, may
> store more info later like Petr mentioned, and also will store the memory
> encryption information of TME (which is intel's transparent memory encryption).
> We can add code comment around to tell these.
Thank you, everyone.
I personally agree with Baoquan's opinion. What do you think about? Boris and other reviewer?
If the vmcoreinfo document is necessary, would you like to help me to provide an outline?
I can try my best to write the document.
Anyway, we should make a choice.
> Personal opinion.