Re: [PATCH 4/4] net: macb: Add support for suspend/resume with full power down
From: Harini Katakam
Date: Wed Oct 31 2018 - 11:02:02 EST
On Wed, Oct 31, 2018 at 8:28 PM Andrew Lunn <andrew@xxxxxxx> wrote:
> On Wed, Oct 31, 2018 at 09:10:23AM +0530, Harini Katakam wrote:
> > When macb device is suspended and system is powered down, the clocks
> > are removed and hence macb should be closed gracefully and restored
> > upon resume. This patch does the same by switching off the net device,
> > suspending phy and performing necessary cleanup of interrupts and BDs.
> > Upon resume, all these are reinitialized again.
> > Reset of macb device is done only when GEM is not a wake device.
> > Even when gem is a wake device, tx queues can be stopped and ptp device
> > can be closed (tsu clock will be disabled in pm_runtime_suspend) as
> > wake event detection has no dependency on this.
> > Signed-off-by: Kedareswara rao Appana <appanad@xxxxxxxxxx>
> > Signed-off-by: Harini Katakam <harini.katakam@xxxxxxxxxx>
> > ---
> > Notes:
> > I was unable to do a full macb_close/open in this patch as suggested
> > because it was freeing and allocating the full RX/TX buffers and
> > this time consuming, also leading to a crash when done continuously
> > in stress tests.
> Hi Harini
> Did you try stress testing just plain up/down, which will call
> macb_open/macb_close? It could be it is broken already, and
> suspend/resume just makes it more obvious it is broken.
Yes, I did. Plain up/down stress tests do not show any problems.