Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

From: Chris Wilson
Date: Fri Nov 02 2018 - 08:16:52 EST


Quoting Robert Foss (2018-11-02 12:13:13)
> If dma_fence_wait fails to wait for a supplied in-fence in
> msm_ioctl_gem_submit, make sure we release that in-fence.
>
> Also remove this dma_fence_put() from the 'out' label.
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Rob, this probably merits a cc:stable tag -- if the wait was interrupted
by a signal, the fence would be leaked.
-Chris