Re: [PATCH] arm64: hide unused swiotlb functions

From: Catalin Marinas
Date: Fri Nov 02 2018 - 13:49:56 EST


On Fri, Nov 02, 2018 at 04:26:07PM +0100, Arnd Bergmann wrote:
> After a good chunk of the swiotlb code has been replaced with the generic
> version, two functions are only used from inside of an #ifdef:
>
> arch/arm64/mm/dma-mapping.c:174:12: error: '__swiotlb_mmap_pfn' defined but not used [-Werror=unused-function]
> static int __swiotlb_mmap_pfn(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~
> arch/arm64/mm/dma-mapping.c:163:12: error: '__swiotlb_get_sgtable_page' defined but not used [-Werror=unused-function]
> static int __swiotlb_get_sgtable_page(struct sg_table *sgt,
>
> Move them into the same #ifdef section to avoid that warning.
>
> Fixes: 886643b76632 ("arm64: use the generic swiotlb_dma_ops")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Christoph already proposed a fix here:

https://marc.info/?l=linux-arm-kernel&m=154091441602535

--
Catalin