Re: [PATCH v2 03/11] ext4 resize: brelse() cleanup in add_new_gdb_meta_bg()

From: Theodore Y. Ts'o
Date: Sat Nov 03 2018 - 16:55:41 EST


On Wed, Oct 31, 2018 at 12:57:55AM +0300, Vasily Averin wrote:
> gdb_bh must be released in case of errors before update of s_group_desc
> but it must not be released after update of group descriptors
> because in this case bh can be used later.
>
> Fixes 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...") # 3.7
>
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>

Thanks, applied. The commit description is not accurate (I suspect it
was obsoleted when your patch for RHEL was forward ported) do I
dropped it.

I adjusted the patch summary to be:

ext4: add missing brelse() add_new_gdb_meta_bg()'s error path

The commments for the Fixes and Cc: stable@xxxxxxxxxx also apply.

- Ted