Re: [PATCH 0/4] irq: fix support for allocating sets of IRQs

From: Jens Axboe
Date: Sat Nov 03 2018 - 17:22:43 EST


On 11/2/18 8:59 AM, Ming Lei wrote:
> Hi Jens,
>
> As I mentioned, there are at least two issues in the patch of '
> irq: add support for allocating (and affinitizing) sets of IRQs':
>
> 1) it is wrong to pass 'mask + usedvec' to irq_build_affinity_masks()
>
> 2) we should spread all possible CPUs in 2-stage way on each set of IRQs
>
> The fix isn't trivial, and I introduce two extra patches as preparation,
> then the implementation can be more clean.
>
> The patchset is against mq-maps branch of block tree, feel free to
> integrate into the whole patchset of multiple queue maps.

Thanks Ming, I ran this through my testing, and I end up with the
same maps and affinities for all the cases I cared about. I'm going
to drop my initial version, and add the three.

--
Jens Axboe