Re: [PATCH v3 2/7] x86/jump_label: Use text_poke_early() during early_init

From: Peter Zijlstra
Date: Mon Nov 05 2018 - 07:40:15 EST


On Fri, Nov 02, 2018 at 04:29:41PM -0700, Nadav Amit wrote:
> diff --git a/init/main.c b/init/main.c
> index a664246450d1..b0fa26637496 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -117,6 +117,8 @@ extern void radix_tree_init(void);
> */
> bool early_boot_irqs_disabled __read_mostly;
>
> +u8 early_boot_done __read_mostly;
> +
> enum system_states system_state __read_mostly;
> EXPORT_SYMBOL(system_state);

Should this not be using system_state ^ ? The site is very close to
SYSTEM_SCHEDULING, can we use that or should we add another state ?

> @@ -735,6 +737,8 @@ asmlinkage __visible void __init start_kernel(void)
> efi_free_boot_services();
> }
>
> + early_boot_done = true;
> +
> /* Do the rest non-__init'ed, we're now alive */
> rest_init();
> }
> --
> 2.17.1
>