Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

From: Peter Zijlstra
Date: Tue Nov 06 2018 - 15:00:21 EST


On Tue, Nov 06, 2018 at 11:51:35AM -0800, Linus Torvalds wrote:
> On Tue, Nov 6, 2018 at 11:42 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > Do you want me to do that patch, or have you already just done it?
>
> I'd rather see it go through something like -tip than doing it myself
> directly, and get at least some of the automated testing before
> unleashing it on an unsuspecting world.
>
> I don't think it will affect much, but there *could* be situations
> where there are some crusty __inline__ users that actually want
> __always_inline behavior.
>
> And we *may* actually have cases where we want the "let compiler make
> a judgement call" behavior, so with this change people will have that
> as an option. But yes, in the short term, it has the possibility of
> regressions due to missed inlining.

Fair enough; I'll do the patch and let it soak a bit in tip.

Thanks!