Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

From: Greg Kroah-Hartman
Date: Wed Nov 07 2018 - 04:15:17 EST


On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote:
> Add a attribute called permissions under vsoc device node for examining
> current granted permissions in vsoc_device.
>
> This file will display permissions in following format:
> begin_offset end_offset owner_offset owned_value
> %x %x %x %x
>
> Signed-off-by: Jerry Lin <wahahab11@xxxxxxxxx>
> ---
> drivers/staging/android/vsoc.c | 48 +++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 45 insertions(+), 3 deletions(-)

What changed from v2? And where was v2? What about v1?

You need a change log here of what you did different from the previous
patches.

And why ignore my response saying that this type of sysfs file is not ok
at all?

thanks,

greg k-h