Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

From: Peter Zijlstra
Date: Wed Nov 07 2018 - 07:19:16 EST


On Mon, Oct 29, 2018 at 06:32:57PM +0000, Patrick Bellasi wrote:
> +struct uclamp_se {
> + unsigned int value : SCHED_CAPACITY_SHIFT + 1;
> + unsigned int group_id : order_base_2(UCLAMP_GROUPS);

Are you sure about ob2() ? seems weird we'll end up with 0 for
UCLAMP_GROUPS==1.

> + unsigned int mapped : 1;
> +};