Re: [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype'

From: Borislav Petkov
Date: Wed Nov 07 2018 - 14:24:01 EST


On Wed, Nov 07, 2018 at 10:22:37AM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/edac/i82975x_edac.c:378:16: warning:
> variable 'dtype' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
>
> Also remove function i82975x_dram_type and move the comment and the
> assignment to the single called place.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: remove unnecessary function i82975x_dram_type
> ---
> drivers/edac/i82975x_edac.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.