Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

From: Genki Sky
Date: Wed Nov 07 2018 - 15:44:02 EST


On Wed, 7 Nov 2018 10:44:37 -0800, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> On Tue, Nov 06, 2018 at 08:00:36PM -0800, Brian Norris wrote:
> > On a different tangent: how about the --no-optional-locks (see
> > git(1))? Will this get you your "up-to-date" result without writing to
> > the .git directory? I've only read the documentation, but not tested
> > it.

This option definitely seems to be what we want, good find.

> Unfortunately, --no-optional-locks is new as of git 2.14. Dunno how new
> of a git we expect people to use.

Hmm, I'm not sure who can speak to this.

Though if it's too recent, then based on earlier discussion, it sounds
like something like this (hack) might work best:

[ -w .git ] &&
touch .git/some-file-here 2>/dev/null &&
git update-index --refresh --unmerged >/dev/null
if git diff-index --name-only HEAD | ...