Re: [PATCH] cpuset: remove set but not used variable 'cs'

[Tom Hromatka]

On 11/07/2018 12:18 AM, Yi Wang wrote:
> This fixes the following warning:
> kernel/cgroup/cpuset.c: In function âcpuset_cancel_attachâ:
> kernel/cgroup/cpuset.c:1501:17: warning: variable âcsâ set but not used [-Wunused-but-set-variable]
>    struct cpuset *cs;
>                   ^
>
> Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>


Reviewed-by: Tom Hromatka <tom.hromatka@xxxxxxxxxx>


> ---
>   kernel/cgroup/cpuset.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 266f10c..784f948 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
>   static void cpuset_cancel_attach(struct cgroup_taskset *tset)
>   {
>   	struct cgroup_subsys_state *css;
> -	struct cpuset *cs;
>   
>   	cgroup_taskset_first(tset, &css);
> -	cs = css_cs(css);
>   
>   	mutex_lock(&cpuset_mutex);
>   	css_cs(css)->attach_in_progress--;