Re: [PATCH v5 0/3] Stingray thermal driver support

From: Florian Fainelli
Date: Wed Nov 07 2018 - 17:15:31 EST




On 10/16/2018 8:11 AM, Srinath Mannam wrote:
> These patches adds the stingray thermal driver and its
> corresponding DT nodes with documentation.

Can we get feedback from the thermal maintains whether this is
acceptable or not?

>
> Changes from v4
> - Addressed Rob Herring comments on DT parameters and
> thermal driver architecture.
> - Removed brcm,max-crit-temp DT parameter
> - Changed driver to thermal sensor registration model.
> - Added trip DT properties.
>
> Changes from v3
> - Addressed Daniel lezcano comments.
> - Elaborated commit description of thermal driver patch.
> - Added brcm,max-crit-temp DT parameter.
>
> Changes from v2:
> - All stingray TMON DT nodes are combine together into single.
> Temperature registers are combined into one mem resource.
> brcm,tmon-mask parameter has available TMONs mask value.
> - All available TMONs are initialized together in single
> instance of driver probe call.
>
> Changes from v1:
> - Fixed auto build sparce warning.
>
> Pramod Kumar (3):
> dt-bindings: thermal: Add binding document for SR thermal
> thermal: broadcom: Add Stingray thermal driver
> arm64: dts: stingray: Add Stingray Thermal DT support.
>
> .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++
> .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++
> drivers/thermal/Kconfig | 3 +-
> drivers/thermal/broadcom/Kconfig | 9 ++
> drivers/thermal/broadcom/Makefile | 1 +
> drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++
> 6 files changed, 344 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> create mode 100644 drivers/thermal/broadcom/sr-thermal.c
>

--
Florian