Re: [PATCH 9/9] csky: use the generic remapping dma alloc implementation

From: Christoph Hellwig
Date: Fri Nov 09 2018 - 02:52:02 EST


On Tue, Nov 06, 2018 at 03:01:41PM +0800, Guo Ren wrote:
> > + return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL));
> > }
> > postcore_initcall(atomic_pool_init);
> Seems also could remove atomic_pool_init from csky, why not put them in
> common?

The code basically moved to common code, but the architecture needs
to pick the gfp mask (GFP_DMA32 on arm vs GFP_KERNEL on csky for example)
and the pgprot it needs for uncached remappings.

> Reviewed-by: Guo Ren <ren_guo@xxxxxxxxx>
>
> Compile is OK, qemu boot OK. Functions are the same and just move to common.

Thanks for your review!