Re: [PATCH] pinctrl: max77620: Use define directive for max77620_pinconf_param values

[Laxman Dewangan]

On Friday 09 November 2018 02:31 PM, Linus Walleij wrote:
> On Thu, Nov 1, 2018 at 1:51 AM Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
>
> > Clang warns when one enumerated type is implicitly converted to another:
> >
> > drivers/pinctrl/pinctrl-max77620.c:56:12: warning: implicit conversion
> > from enumeration type 'enum max77620_pinconf_param' to different
> > enumeration type 'enum pin_config_param' [-Wenum-conversion]
> >                  .param = MAX77620_ACTIVE_FPS_SOURCE,
> >                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > It is expected that pinctrl drivers can extend pin_config_param because
> > of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
> > isn't an issue. Most drivers that take advantage of this define the
> > PIN_CONFIG variables as constants, rather than enumerated values. Do the
> > same thing here so that Clang no longer warns.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/139
> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Patch tentatively applied.
>
> This seems to be the direction we need to be going with a lot
> of CLANG business.
>
> Laxman: you weren't CCed, so tell us if you dislike it for some
> reason.
Looked changes and it is great. MISRA-C also happy with macros instead 
of enum.

Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>