Re: [PATCH v3 1/4] x86/mm: declare check_la57_support() as inline

From: Masahiro Yamada
Date: Fri Nov 09 2018 - 11:28:21 EST


On Fri, Nov 2, 2018 at 8:28 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Mon, Oct 29, 2018 at 10:04:46PM +0900, Masahiro Yamada wrote:
> > On Mon, Oct 29, 2018 at 3:09 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > On Sun, 28 Oct 2018 13:09:42 +0000
> > > Changbin Du <changbin.du@xxxxxxxxx> wrote:
> > >
> > > > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled.
> > > > So declare check_la57_support() as inline to make sure the code
> > > > referring to level4_kernel_pgt is optimized out. This is a preparation
> > > > for CONFIG_CC_OPTIMIZE_FOR_DEBUGGING.
> > > >
> > > > Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>
> > >
> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > >
> > > -- Steve
> > >
> >
> > Applied to linux-kbuild.
>
> Next time, before you route a patch through your tree, please get an x86
> maintainer's ACK first.


I changed my mind, and did not include this in my previous pull request
because this series is causing many warnings.

Now, it is aiming for v5.0-rc1

So, it is not too late.

If x86 maintainers issue Acked-by,
I am happy to add it.




> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.



--
Best Regards
Masahiro Yamada