Re: [PATCH 1/3] gpio: mockup: fix indicated direction
From: Uwe Kleine-König
Date: Sun Nov 11 2018 - 11:59:43 EST
On Fri, Nov 09, 2018 at 06:23:01PM +0100, Bartosz Golaszewski wrote:
> pt., 9 lis 2018 o 18:03 Uwe Kleine-KÃnig
> <u.kleine-koenig@xxxxxxxxxxxxxx> napisaÅ(a):
> >
> > Hello Bartosz,
> >
> > On Fri, Nov 09, 2018 at 04:24:10PM +0100, Bartosz Golaszewski wrote:
> > > pt., 9 lis 2018 o 15:39 Uwe Kleine-KÃnig
> > > <u.kleine-koenig@xxxxxxxxxxxxxx> napisaÅ(a):
> > > > On Fri, Nov 09, 2018 at 02:53:16PM +0100, Bartosz Golaszewski wrote:
> > > > > pt., 9 lis 2018 o 14:10 Uwe Kleine-KÃnig
> > > > > <u.kleine-koenig@xxxxxxxxxxxxxx> napisaÅ(a):
> > > > > > Which test failed exactly?
> > > > >
> > > > > All gpioinfo tests that check the output of this command and expect to
> > > > > see input as line direction.
> > > >
> > > > This wasn't the answer I expected. The background of my question was:
> > > > This failing test seems to expect that a given GPIO is an input. If that
> > > > expectation already exists after the gpio is only requested, then the
> > > > test is broken and a fix is necessary there.
> > >
> > > The test is only expected to work with gpio-mockup which is a dummy
> > > testing module. I believe its behavior should be as deterministic as
> > > possible to the point where newly created chips always have the same
> > > direction.
> >
> > Given that the initial direction of a GPIO isn't fixed in my eyes the
> > test should be able to cope with both possibilities. I'd say it's a bug
> > in the test if it doesn't.
> >
>
> As I said before: it is and should be fixed in this specific case.
> This isn't real hardware.
Not sure if we agree here yet. What do you want to fix? The driver or
the test?
In my eyes test driven development is great. But if something breaks
because the test is wrong, please don't "fix" the system to repair the
test, but modify the test to be able to handle reality.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-KÃnig |
Industrial Linux Solutions | http://www.pengutronix.de/ |