Re: [PATCH V2] cacheinfo: Keep the old value if of_property_read_u32 fails

From: Greg Kroah-Hartman
Date: Sun Nov 11 2018 - 14:29:12 EST


On Fri, Oct 19, 2018 at 09:31:29PM +0800, Huacai Chen wrote:
> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> property_read_u32 instead of get_property,read_number") makes cache
> size and number_of_sets be 0 if DT doesn't provide there values. I
> think this is unreasonable so make them keep the old values, which is
> the same as old kernels.
>
> Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
> Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
> drivers/base/cacheinfo.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

What changed from v1? Always put that below the --- line.

Please fix this up and resend a v3.

thanks,

greg k-h