Re: [PATCH v5 2/4] dt-bindings: iio: adc: Add common ADCs properties to a separate file

From: Rob Herring
Date: Fri Nov 16 2018 - 17:53:08 EST


On Fri, Nov 16, 2018 at 06:38:38PM +0000, Jonathan Cameron wrote:
> On Tue, 13 Nov 2018 13:21:01 +0200
> Stefan Popa <stefan.popa@xxxxxxxxxx> wrote:
>
> > There are several ADC drivers that depend on the same device tree
> > bindings. Rather than continue to duplicate the properties, this patch
> > adds a common adc binding document that can be referenced. For beginning,
> > only two properties are documented.
> >
> > Signed-off-by: Stefan Popa <stefan.popa@xxxxxxxxxx>
> Looks very sensible to me, but as we are looking at a some generalization
> here, I'd like an Ack from Rob if possible (as he suggested it I think :)

Looks fine to me, but I don't have any clue if this will be flexible
enough for various h/w.

Rob