Re: [PATCH v2] net: phy: mdio-gpio: fix access that may sleep

From: David Miller
Date: Fri Nov 16 2018 - 22:52:33 EST


From: Martin Schiller <ms@xxxxxxxxxx>
Date: Wed, 14 Nov 2018 07:37:03 +0100

> @@ -162,6 +162,11 @@ static int mdio_gpio_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> + if (gpiod_cansleep(bitbang->mdc) || gpiod_cansleep(bitbang->mdio)
> + || gpiod_cansleep(bitbang->mdo))

Please fix the formatting here, operators like "||" and "&&" never begin
a line, they must always finish a line.