Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

From: Tim Chen
Date: Mon Nov 19 2018 - 20:14:15 EST


On 11/19/2018 04:30 PM, Thomas Gleixner wrote:
>
> What has spectre_v2=on to do with spectre_v2_app2app=on?
>
> Exactly nothing. You can have 'on' for both. The only side effect of
> spectre_v2=on is that it also forces spectre_v2_app2app to 'on'
> irrespective of what eventually was added for spectre_v2_app2app= on the
> command line.
>
>> What will you like to name the "lite" and "strict" option instead?
>
> 'prctl' and 'on' and if we add 'seccomp' then this is exactly the same as
> we have for ssbd.
>
>>> Can we please have a full documentation for all the spectre_v2 stuff
>>> similar to l1tf?
>>>
>> Sure. Can we do that as a separate patch? I'll need some time
>> and internal review for any spectre_v2 documentation that's produced.
>
> I'm not taking that stuff without proper documentation. I complained about
> that vs. L1TF and got told that no sysadmin cares, but L1TF has shown that
> they care very much and appreciate proper documentation.
>
> Nobody can oracle the protection scope out of that inconsistent command
> line maze.
>

Thomas,

I'm not a good writer and it will take me some time to have the documentation
and boot options code ironed out. In the mean time, will it make sense
to revert Jiri's patchset, till we have this patchset and associated
documentation updated to everyone's liking?

Thanks.

Tim