Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

From: Oliver Neukum
Date: Tue Nov 20 2018 - 10:22:23 EST



> Anytime "in_reset" is set "quiescing" is also set:
>
> static int hub_pre_reset(struct usb_interface *intf)
> {
> struct usb_hub *hub = usb_get_intfdata(intf);
>
> hub_quiesce(hub, HUB_PRE_RESET); //sets quiesce
> hub->in_reset = 1;
> hub_pm_barrier_for_all_ports(hub);
> return 0;
> }
>
> static int hub_post_reset(struct usb_interface *intf)
> {
> struct usb_hub *hub = usb_get_intfdata(intf);
>
> hub->in_reset = 0;
> hub_pm_barrier_for_all_ports(hub);
> hub_activate(hub, HUB_POST_RESET); //clears quiesce
> return 0;
> }
>
> I should be OK isn't it?

Sorry, yes, I overlooked that there are two flags.

Regards
Oliver