Re: [PATCH 05/10] staging: erofs: add a full barrier in erofs_workgroup_unfreeze

From: Gao Xiang
Date: Thu Nov 22 2018 - 05:56:56 EST


Hi Greg,

On 2018/11/22 18:22, Greg Kroah-Hartman wrote:
> Please document this memory barrier. It does not make much sense to
> me...

Because we need to make the other observers noticing the latest values modified
in this locking period before unfreezing the whole workgroup, one way is to use
a memory barrier and the other way is to use ACQUIRE and RELEASE. we selected
the first one.

Hmmm...ok, I will add a simple message to explain this, but I think that is
plain enough for a lock...

Thanks,
Gao Xiang

>
> thanks,
>
> greg k-h