Re: [PATCH] scripts: use pkg-config to locate libcrypto

From: David Woodhouse
Date: Thu Nov 22 2018 - 11:17:02 EST


On Thu, 2018-11-22 at 16:45 +0100, Rolf Eike Beer wrote:
> -HOSTLDLIBS_sign-file = -lcrypto
> -HOSTLDLIBS_extract-cert = -lcrypto
> +HOSTLDLIBS_sign-file = $(shell $(PKG_CONFIG) --libs libcrypto 2> /dev/null || -lcrypto)
> +HOSTCFLAGS_extract-cert.o = $(shell $(PKG_CONFIG) --cflags libcrypto 2> /dev/null)
> +HOSTLDLIBS_extract-cert = $(shell $(PKG_CONFIG) --libs libcrypto 2> /dev/null || -lcrypto)


Looks good; thanks. But could you put it into intermediate
CRYPTO_CFLAGS and CRYPTO_LIBS variables instead of calculating the
latter in two separate callouts?

Attachment: smime.p7s
Description: S/MIME cryptographic signature