Re: [patch V2 19/28] x86/process: Consolidate and simplify switch_to_xtra() code

[Borislav Petkov]

On Sun, Nov 25, 2018 at 07:33:47PM +0100, Thomas Gleixner wrote:
> Move the conditional invocation of __switch_to_xtra() into an inline
> function so the logic can be shared between 32 and 64 bit.
> 
> Remove the handthrough of the TSS pointer and retrieve the pointer directly

s/handthrough/passing/

I guess.

> in the bitmap handling function. Use this_cpu_ptr() instead of the
> per_cpu() indirection.
>
> This is a preparatory change so integration of conditional indirect branch
> speculation optimization happens only in one place.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  arch/x86/include/asm/switch_to.h |    3 ---
>  arch/x86/kernel/process.c        |   12 +++++++-----
>  arch/x86/kernel/process.h        |   24 ++++++++++++++++++++++++
>  arch/x86/kernel/process_32.c     |   10 +++-------
>  arch/x86/kernel/process_64.c     |   10 +++-------
>  5 files changed, 37 insertions(+), 22 deletions(-)

...

> --- /dev/null
> +++ b/arch/x86/kernel/process.h
> @@ -0,0 +1,24 @@
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Code shared between 32 and 64 bit

checkpatch mutters here too:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#105: FILE: arch/x86/kernel/process.h:1:
+// SPDX-License-Identifier: GPL-2.0

I guess you want /* comments.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.