Re: [PATCH] arm: always update thread_info->syscall

From: Russell King - ARM Linux
Date: Mon Nov 26 2018 - 18:41:41 EST


On Mon, Nov 26, 2018 at 11:33:03PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote:
> > Right now, only way for task->thread_info->syscall to be updated is if
> > if _TIF_SYSCALL_WORK is set in current's task thread_info->flags
> > (similar to what has_syscall_work() checks for arm64).
> >
> > This means that "->syscall" will only be updated if we are tracing the
> > syscalls through ptrace, for example. This is NOT the same behavior as
> > arm64, when pt_regs->syscallno is updated in the beginning of svc0
> > handler for *every* syscall entry.
>
> So when was it decided that the syscall number will always be required
> (we need it to know how far back this has to be backported).

PS, I rather object to the fact that the required behaviour seems to
change, arch maintainers aren't told about it until... some test is
created at some random point in the future which then fails.

Surely there's a better way to communicate changes in requirements
than discovery-by-random-bug-report ?

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up